Add attest-blob command #2286
Add attest-blob command #2286
Conversation
This mostly copies the functionality of image attestation and blob signing. Signed-off-by: Michael <[email protected]>
priyawadhwa
force-pushed
the
sign-attestation-blob
branch
from
3173ce7
to
d530294
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2286 +/- ##
==========================================
- Coverage 30.18% 29.84% -0.34%
==========================================
Files 131 133 +2
Lines 8089 8181 +92
==========================================
Hits 2442 2442
- Misses 5323 5415 +92
Partials 324 324 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Priya Wadhwa <[email protected]>
priyawadhwa
force-pushed
the
sign-attestation-blob
branch
2 times, most recently
from
de01a17
to
4c6cb43
Compare
Signed-off-by: Priya Wadhwa <[email protected]>
priyawadhwa
force-pushed
the
sign-attestation-blob
branch
from
4c6cb43
to
7a098b3
Compare
Signed-off-by: Priya Wadhwa <[email protected]>
Signed-off-by: Priya Wadhwa <[email protected]>
priyawadhwa
force-pushed
the
sign-attestation-blob
branch
from
54920b0
to
919f348
Compare
Signed-off-by: Priya Wadhwa <[email protected]>
priyawadhwa
force-pushed
the
sign-attestation-blob
branch
from
919f348
to
5b76402
Compare
|
Thanks so much for doing this! Would it be possible to add an e2e test for this functionality like here (hopefully mainly copy&paste if we want a new test leg, or just add a new test case in the existing one (sign/verify) (not worrying about the now overbaked testfile name :) ): I'd be happy to add this myself but might not get to it for day or twoish |
|
@vaikas would it be ok if i did it in a follow-up pr? my next one is gonna be for the |
|
Oh, absolutely, that's perfetto! |
Built on top of #1265, thank you mlieberman85!
This is just the signing piece, we will need
cosign verify-attest-blobas well which I'll do in a follow-up PR.Once that's in I'll add in the unit and integration tests!